yx91490 commented on code in PR #1747:
URL: 
https://github.com/apache/incubator-seatunnel/pull/1747#discussion_r858624869


##########
seatunnel-core/seatunnel-core-spark/src/main/java/org/apache/seatunnel/SparkStarter.java:
##########
@@ -293,6 +296,24 @@ protected void appendAppJar(List<String> commands) {
         
commands.add(Common.appLibDir().resolve("seatunnel-core-spark.jar").toString());
     }
 
+    /**
+     * change file location to get config file on yarn cluster mode
+     */
+    protected void changeFileLocation() {
+        if 
(DeployMode.CLUSTER.getName().equals(this.commandArgs.getDeployMode().getName()))
 {
+            String regEx = ".+/(.+)$";
+            Pattern p = Pattern.compile(regEx);
+            for (int i = 1; i < args.length; i++) {
+                if ("-c".equals(args[i - 1]) || "--config".equals(args[i - 
1])) {
+                    Matcher m = p.matcher(args[i]);
+                    if (m.find()) {
+                        args[i] = m.group(1);

Review Comment:
   this patch seems not graceful enough:(



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to