zhongjiajie commented on code in PR #1740: URL: https://github.com/apache/incubator-seatunnel/pull/1740#discussion_r859343626
########## docs/en/faq.md: ########## @@ -1,11 +1,8 @@ # FAQ -why-i-should-install-computing-engine-like-spark-or-flink - ## Why I should install computing engine like Spark or Flink -<!-- We should add the reason --> -TODO +Now SeaTunnel uses computing engines like spark and flink to complete resource scheduling and node communication, so we can focus on the ease of use of data synchronization and the development of high-performance components. But this is only temporary. Review Comment: ```suggestion Now SeaTunnel uses computing engines such as spark and flink to complete resource scheduling and node communication, so we can focus on the ease of use of data synchronization and the development of high-performance components. But this is only temporary. ``` ########## docs/en/start/config.md: ########## @@ -0,0 +1,108 @@ +--- +sidebar_position: 5 +--- + +# Intro to config file Review Comment: I do not think we should put `config.md` in the start section. This will make our structure not clear, because both local, docker, and k8s are the way to bring ST up, but config is for all kind of deployment. I personally prefer to add a new parent sidebar named `how to` or `concept` to put some "usage" or "common" docs like that. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
