[GitHub] [incubator-seatunnel] gleiyu commented on a diff in pull request #1781: [Bug] [flink-connector-jdbc]change jdbc Source connector to get fields from jdbc meta data and support oracle database

Thu, 05 May 2022 18:56:11 -0700 


gleiyu commented on code in PR #1781:
URL: 
https://github.com/apache/incubator-seatunnel/pull/1781#discussion_r866436704


##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/jdbc/source/JdbcSource.java:
##########
@@ -273,12 +234,13 @@ private RowTypeInfo getRowTypeInfo() {
         return new RowTypeInfo(typeInformation, names);
     }
 
-    private TypeInformationMap getTypeInformationMap(String driverName) {
-        driverName = driverName.toLowerCase();
-        if (driverName.contains("mysql")) {
+    private TypeInformationMap getTypeInformationMap(String databaseDialect) {
+        if ("mysql".equalsIgnoreCase(databaseDialect)) {
             return new MysqlTypeInformationMap();
-        } else if (driverName.contains("postgresql")) {
+        } else if ("postgresql".equalsIgnoreCase(databaseDialect)) {
             return new PostgresTypeInformationMap();
+        } else if ("oracle".equalsIgnoreCase(databaseDialect)) {
+            return new OracleTypeInformationMap();

Review Comment:
   I checked it in ojdbc source
   
![image](https://user-images.githubusercontent.com/4036309/167054129-cff47e38-89ff-446c-97ec-fe5f8c30f15c.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to