BenJFan commented on PR #1800: URL: https://github.com/apache/incubator-seatunnel/pull/1800#issuecomment-1119232864
> Hi, @BenJFan , thanks for the reply. Let's have a brief discussion. > > There are several pros in this implementation setting the configurations in '-D': > > * simple. Config in shell is simple enough, and Flink client will do much work for us. If we set them in environment, we have to set them for each environments (stream, batch, table) > * upgrade. Environment API upgrade has no side effect to our current implementation. > > What do you think? > > Thanks, Kelu Got it. You are right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
