lonelyGhostisdog opened a new pull request, #1856:
URL: https://github.com/apache/incubator-seatunnel/pull/1856

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code 
changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB 
issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the 
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix 
typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull 
request adds checkstyle plugin.-->
   add Hudi sink 
[#1830](https://github.com/apache/incubator-seatunnel/issues/1830). 
   I tried to finish it in one of two ways
   - The first is what I push, creating a new Hudi table and inserting it with 
an INSERT into statement
   - The second is to emulate the practice in `hud-flink` by concatenating 
multiple datastreams to write data to the HUDI table
   
   The first way was lightweight and we didn't need to change it when Hudi was 
upgraded.
   The second way will have a lot of duplicate codes from `Hudi - Flink`, and 
some codes we need to be inconsistent with `hudi -flink`, when the HUDI version 
changes, we need to modify our code.
   
   So, i chooice the first way.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for 
reason:
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to