ruanwenjun commented on code in PR #1882:
URL:
https://github.com/apache/incubator-seatunnel/pull/1882#discussion_r873143008
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-doris/src/main/java/org/apache/seatunnel/flink/doris/sink/DorisOutputFormat.java:
##########
@@ -207,7 +207,7 @@ public synchronized void flush() throws IOException {
result = OBJECT_MAPPER.writeValueAsString(batch);
}
} else {
- result = String.join(this.lineDelimiter, batch.toArray(new
CharSequence[batch.size()]));
+ result = String.join(this.lineDelimiter, batch.toArray(new
CharSequence[0]));
Review Comment:
@legendtkl Maybe we need to add a benchmark module, then we can easy to test
this kind of case. https://github.com/apache/kafka/tree/trunk/jmh-benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
