CalvinKirs commented on code in PR #1878:
URL:
https://github.com/apache/incubator-seatunnel/pull/1878#discussion_r873635729
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -644,6 +645,7 @@ snakeyaml-1.24.jar
snappy-0.3.jar
snappy-java-1.1.4.jar
snappy-java-1.1.7.1.jar
+snappy-java-1.1.7.3.jar
Review Comment:
needs the test, but you can create a new PR after your test is done. (If
updated can great work)
> It looks the dependency include the snappy inside
>
> ```
> <dependency>
> <groupId>org.apache.flink</groupId>
> <artifactId>flink-connector-kafka_2.11</artifactId>
> <version>${flink.version}</version>
> </dependency>
> ```
>
> use `mvn dependency:tree`
>
> ```
> [INFO] org.apache.seatunnel:flink-sql-connector-kafka:jar:2.1.1-SNAPSHOT
> [INFO] +- org.apache.flink:flink-connector-kafka_2.11:jar:1.13.6:compile
> [INFO] | +- org.apache.kafka:kafka-clients:jar:2.4.1:compile
> [INFO] | | +- com.github.luben:zstd-jni:jar:1.4.3-1:compile
> [INFO] | | +- org.lz4:lz4-java:jar:1.6.0:compile
> [INFO] | | +- org.xerial.snappy:snappy-java:jar:1.1.7.3:compile
> [INFO] | | \- org.slf4j:slf4j-api:jar:1.7.28:compile
> [INFO] | +- org.apache.flink:flink-connector-base:jar:1.13.6:compile
> [INFO] | \- org.apache.flink:force-shading:jar:1.13.6:compile
> ```
>
> I'm not sure if that's a good idea to exclude the snappy(1.1.7.3) from
`flink-connector-kafka_2.11` and add 1.1.7.1 into module dependency.
>
> Do you have any ideas ？ @CalvinKirs
needs the test, but you can create a new PR after your test is done. (If
updated can good to work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
