chenhu commented on code in PR #1876:
URL: 
https://github.com/apache/incubator-seatunnel/pull/1876#discussion_r874289997


##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-tidb/pom.xml:
##########
@@ -60,6 +60,10 @@
                     <groupId>mysql</groupId>
                     <artifactId>mysql-connector-java</artifactId>
                 </exclusion>
+                <exclusion>
+                    <groupId>org.apache.spark</groupId>
+                    <artifactId>spark-sql_${scala.binary.version}}</artifactId>
+                </exclusion>

Review Comment:
   In the root pom, the dependency of tispark-assembly version of 2.4.1, maybe 
it's indirect dependency of spark-sql version is right for current  root 
spark-sql version, but the version of tispark-assembly not bind to the root pom 
of seatunnel, it's a risk I think. 
   
   exclude the dependency of spark-sql from tispark-assembly will reduce the 
risk, no matter how.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to