BenJFan commented on code in PR #1872:
URL:
https://github.com/apache/incubator-seatunnel/pull/1872#discussion_r881521564
##########
seatunnel-dist/release-docs/LICENSE:
##########
@@ -896,6 +896,7 @@ The text of each license is the standard Apache 2.0 license.
(The Apache Software License, Version 2.0) transport-netty4
(org.elasticsearch.plugin:transport-netty4-client:7.5.1 -
https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) x-content
(org.elasticsearch:elasticsearch-x-content:6.3.1 -
https://github.com/elastic/elasticsearch)
(The Apache Software License, Version 2.0) zookeeper
(org.apache.zookeeper:zookeeper:3.4.10 - no url defined)
+ (The Apache Software License, Version 2.0) spark-excel
(com.crealytics:spark-excel_2.11:0.11.1 -
https://github.com/crealytics/spark-excel)
Review Comment:
Seem like you should add other license in this file. like
```
poi-4.0.0.jar
poi-ooxml-4.0.0.jar
poi-ooxml-schemas-4.0.0.jar
```
They are new jar you add on known-dependcies.txt, so you should add license
link on this file, you can copy example from already exist license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
