ruanwenjun commented on code in PR #2022:
URL: 
https://github.com/apache/incubator-seatunnel/pull/2022#discussion_r900280410


##########
seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/batch/FlinkBatchExecution.java:
##########
@@ -118,6 +118,6 @@ public Config getConfig() {
     }
 
     private boolean whetherExecute(List<FlinkBatchSink> sinks) {
-        return sinks.stream().anyMatch(s -> 
!"ConsoleSink".equals(s.getPluginName()));
+        return sinks.stream().anyMatch(s -> 
!"ConsoleSink".equals(s.getPluginName()) && 
!"AssertSink".equals(s.getPluginName()));

Review Comment:
   In my knowledge, you cannot add this check here, this will not call execute 
method, so your flink job will not be submitted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to