Hisoka-X commented on PR #2030:
URL: 
https://github.com/apache/incubator-seatunnel/pull/2030#issuecomment-1160209518

   > > > > It seems we can only use profile to deal with different JDK, 
although this will make thing conplex.
   > > > > BTW, the module name `seatunnel-connectors-common` is confusion, I 
don't think we need to add hadoop dependency in the common mudule.
   > > > 
   > > > 
   > > > OK, what name do you think is more appropriate?
   > > 
   > > 
   > > I had change it to `seatunnel-connector-hadoop-shade`, is it ok?
   > 
   > I am afraid we need more shade jar in the feature. like hadoop2-shade, 
hadoop3-shade, hive1.2-shade, hive2-shade, hive3-shade ... xxx-shade . So I 
think we should put this shade modules into a same parent module.
   
   Or call `seatunnel-connector-shade`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to