lhyundeadsoul commented on code in PR #2055:
URL:
https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905993237
##########
pom.xml:
##########
@@ -433,6 +434,11 @@
<artifactId>commons-lang3</artifactId>
<version>${commons-lang3.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-collections4</artifactId>
+ <version>${commons-collections4.version}</version>
+ </dependency>
Review Comment:
> you can refer this
https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md
I have 2 questions after trying add new license refering this page.
1. I got following message after the 3rd step. Is this normal?
```
> $ python3 tools/dependencies/license.py
seatunnel-dist/target/THIRD-PARTY.txt seatunnel-dist/release-docs/LICENSE true
[±assertsink4apidraft ●]
(Unknown license) jsch (com.jcraft:jsch:0.1.54 - no url defined)
(Unknown license) disruptor (com.lmax:disruptor:3.3.6 - no url defined)
(Unknown license) Commons IO (commons-io:commons-io:2.4 -
http://commons.apache.org/io/)
(Unknown license) commons-net (commons-net:commons-net:3.6 - no url defined)
(Unknown license) joda-time (joda-time:joda-time:1.6 - no url defined)
(Unknown license) "Java Concurrency in Practice" book annotations
(net.jcip:jcip-annotations:1.0 - http://jcip.net/)
(Unknown license) stringtemplate (org.antlr:stringtemplate:3.2.1 - no url
defined)
(Unknown license) libthrift (org.apache.thrift:libthrift:0.9.0 - no url
defined)
(Bouncy Castle Licence) Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP,
and CRMF APIs (org.bouncycastle:bcpkix-jdk15on:1.68 -
http://www.bouncycastle.org/java.html)
(Bouncy Castle Licence) Bouncy Castle Provider
(org.bouncycastle:bcprov-ext-jdk15on:1.68 -
https://www.bouncycastle.org/java.html)
(Bouncy Castle Licence) Bouncy Castle Provider
(org.bouncycastle:bcprov-jdk15on:1.68 - http://www.bouncycastle.org/java.html)
(Unknown license) xz (org.tukaani:xz:1.5 - no url defined)
(Unknown license) stax-api (stax:stax-api:1.0.1 - no url defined)
Please confirm the license by finding LICENSE file in the corresponding Jar
file and maintain it in the dependency_licenses_map instance.
```
2. There is no detail instruction in 4th step. I don't know what to do for
this step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
