EricJoy2048 commented on code in PR #2117:
URL:
https://github.com/apache/incubator-seatunnel/pull/2117#discussion_r912833231
##########
seatunnel-e2e/pom.xml:
##########
@@ -34,4 +34,22 @@
<module>seatunnel-flink-sql-e2e</module>
</modules>
+ <dependencies>
Review Comment:
> We don't need to add connector-dist dependency into e2e, the e2e module
find the connector jar from connector module and submit it to docker. If we add
the connector-dist to e2e, we need to update the e2e base class, otherwise, the
dependency is not used.
I remove the dependency now.
##########
seatunnel-e2e/pom.xml:
##########
@@ -34,4 +34,22 @@
<module>seatunnel-flink-sql-e2e</module>
</modules>
+ <dependencies>
Review Comment:
> We don't need to add connector-dist dependency into e2e, the e2e module
find the connector jar from connector module and submit it to docker. If we add
the connector-dist to e2e, we need to update the e2e base class, otherwise, the
dependency is not used.
I removed the dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
