lhyundeadsoul opened a new issue, #2127:
URL: https://github.com/apache/incubator-seatunnel/issues/2127

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22bug%22)
 and found no similar issues.
   
   
   ### Describe the proposal
   
   There are some code suggestion to the implementation of `new connector api` 
. These may promote the code understandable, unambiguous, and reasonable. 
   Please let me know if I didn't understand the code design exactly. Thx.
   
   ### Task list
   
   - [ ] `SingleSplitReaderContext `
     - [ ] ` 
https://github.com/apache/incubator-seatunnel/pull/2041#discussion_r912950907
   - [ ] `SeaTunnelRuntimeEnvironment `
     - [ ] 
https://github.com/apache/incubator-seatunnel/pull/2041#discussion_r912962254
   - [ ] `org.apache.seatunnel.api.source.SourceSplitEnumerator.Context`
     - [ ] `registeredReaders`,`assignSplit(int, java.util.List<SplitT>)` and 
`signalNoMoreSplits(int subtask)` seems belong to `SplitEnumerator` behavior, 
not the `Context`
     - [ ] 
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to