CalvinKirs commented on code in PR #2301:
URL:
https://github.com/apache/incubator-seatunnel/pull/2301#discussion_r935149422
##########
seatunnel-engine/seatunnel-engine-client/src/main/java/org/apache/seatunnel/engine/client/JobConfigParser.java:
##########
@@ -63,22 +67,26 @@ public class JobConfigParser {
private Map<String, List<Config>> sourceResultTableNameMap = new
HashMap<>();
+ private List<Action> actions = new ArrayList<>();
+ private Set<URL> jarUrlsSet = new HashSet<>();
+
protected JobConfigParser(@NonNull String jobDefineFilePath, @NonNull
IdGenerator idGenerator) {
this.jobDefineFilePath = jobDefineFilePath;
this.idGenerator = idGenerator;
}
- public List<Action> parse() {
+ public ImmutablePair<List<Action>, Set<URL>> parse() {
Config seaTunnelJobConfig = new
ConfigBuilder(Paths.get(jobDefineFilePath)).getConfig();
List<? extends Config> sinkConfigs =
seaTunnelJobConfig.getConfigList("sink");
List<? extends Config> transformConfigs =
seaTunnelJobConfig.getConfigList("transform");
List<? extends Config> sourceConfigs =
seaTunnelJobConfig.getConfigList("source");
if (sinkConfigs.size() == 1 && sourceConfigs.size() == 1 &
transformConfigs.size() <= 1) {
Review Comment:
Is there a risk of NPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
