CalvinKirs commented on code in PR #2358:
URL:
https://github.com/apache/incubator-seatunnel/pull/2358#discussion_r937309397
##########
seatunnel-engine/seatunnel-engine-client/src/test/java/org/apache/seatunnel/engine/client/SeaTunnelClientTest.java:
##########
@@ -67,9 +66,8 @@ public void testExecuteJob() {
jobConfig.setBoundedness(Boundedness.BOUNDED);
jobConfig.setName("fake_to_file");
- SeaTunnelClientConfig seaTunnelClientConfig = new
SeaTunnelClientConfig();
-
seaTunnelClientConfig.getNetworkConfig().setAddresses(Lists.newArrayList("localhost:50001"));
- SeaTunnelClient engineClient = new
SeaTunnelClient(seaTunnelClientConfig);
+ ClientConfig clientConfig = ConfigProvider.locateAndGetClientConfig();
+ SeaTunnelClient engineClient = new SeaTunnelClient(clientConfig);
JobExecutionEnvironment jobExecutionEnv =
engineClient.createExecutionContext(filePath, jobConfig);
JobProxy jobProxy = jobExecutionEnv.execute();
Review Comment:
This UT has no judgment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
