[GitHub] [incubator-seatunnel] hanwei996 commented on a diff in pull request #2356: Modify conversion error, new increase format match

Fri, 05 Aug 2022 09:30:42 -0700 


hanwei996 commented on code in PR #2356:
URL: 
https://github.com/apache/incubator-seatunnel/pull/2356#discussion_r938979595


##########
seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/util/SchemaUtil.java:
##########
@@ -117,8 +120,27 @@ public static FormatDescriptor setFormat(FormatType 
format, Config config) throw
         return formatDescriptor;
     }
 
-    private static void getJsonSchema(Schema schema, ObjectNode json) {
-        Iterator<Map.Entry<String, JsonNode>> nodeIterator = json.fields();
+    private static void getJsonSchema(Schema schema, String json) {

Review Comment:
   The Flink schema is not familiar enough to know if this is the right thing 
to do
   
![image](https://user-images.githubusercontent.com/43572770/183120889-0a3fa3ea-e9ea-45d1-a4ff-334eac8f27f5.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to