ic4y commented on code in PR #2366:
URL:
https://github.com/apache/incubator-seatunnel/pull/2366#discussion_r942120301
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -156,7 +171,162 @@ private final class BlockingTaskThreadFactory implements
ThreadFactory {
@Override
public Thread newThread(@NonNull Runnable r) {
return new Thread(r,
- String.format("hz.%s.seaTunnel.blocking.thread-%d",
hzInstanceName, seq.getAndIncrement()));
+ String.format("hz.%s.seaTunnel.task.thread-%d",
hzInstanceName, seq.getAndIncrement()));
+ }
+ }
+
+ /**
+ * BusWork is used to poll the task call method,
+ * When a task times out, a new BusWork will be created to take over the
execution of the task
+ */
+ public final class BusWork implements Runnable {
+
+ AtomicBoolean keep = new AtomicBoolean(true);
+ public AtomicReference<TaskTracker> exclusiveTaskTracker = new
AtomicReference<>();
+ final TaskCallTimer timer;
+ public LinkedBlockingDeque<TaskTracker> taskqueue;
+
+ @SuppressWarnings("checkstyle:MagicNumber")
+ public BusWork(LinkedBlockingDeque<TaskTracker> taskqueue,
RunBusWorkSupplier runBusWorkSupplier) {
Review Comment:
I don't think this place needs priority, just FIFO is enough.The execution
of the task will be very fast. Even if a task executes slowly, it will not
block subsequent tasks.
This is dynamic thread sharing optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
