Hisoka-X commented on code in PR #2393:
URL:
https://github.com/apache/incubator-seatunnel/pull/2393#discussion_r943220791
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSink.java:
##########
@@ -78,7 +78,14 @@ public String getPluginName() {
@SuppressWarnings("checkstyle:MagicNumber")
@Override
public void prepare(Config config) throws PrepareFailException {
- CheckResult result = CheckConfigUtil.checkAllExists(config, HOST,
DATABASE, TABLE, USERNAME, PASSWORD);
+ CheckResult result = CheckConfigUtil.checkAllExists(config, HOST,
DATABASE, TABLE);
+
+ boolean isCredential = config.hasPath(USERNAME) &&
config.hasPath(PASSWORD);
Review Comment:
```suggestion
boolean isCredential = config.hasPath(USERNAME) ||
config.hasPath(PASSWORD);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
