CalvinKirs commented on code in PR #2410:
URL:
https://github.com/apache/incubator-seatunnel/pull/2410#discussion_r945436368
##########
pom.xml:
##########
@@ -352,6 +353,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.ibm.db2</groupId>
+ <artifactId>jcc</artifactId>
+ <version>${db2.version}</version>
+ </dependency>
Review Comment:
These are two different things, for new connectors we don't need to publish
binary packages, so we don't have to add these, for Jdbc we don't provide this
dependency, so you need to change this dependency scope to `provide`. The
meaning of `test` is too vague.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
