EricJoy2048 commented on code in PR #2413:
URL:
https://github.com/apache/incubator-seatunnel/pull/2413#discussion_r949731384
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalVertex.java:
##########
@@ -145,26 +142,35 @@ public PhysicalVertex(long physicalVertexId,
@SuppressWarnings("checkstyle:MagicNumber")
// This method must not throw an exception
public void deploy(@NonNull Address address) {
-
- TaskGroupImmutableInformation taskGroupImmutableInformation =
- new TaskGroupImmutableInformation(flakeIdGenerator.newId(),
-
nodeEngine.getSerializationService().toData(this.taskGroup),
- this.pluginJarsUrls);
-
- try {
- waitForCompleteByExecutionService = new NonCompletableFuture<>(
-
nodeEngine.getOperationService().createInvocationBuilder(Constant.SEATUNNEL_SERVICE_NAME,
- new
DeployTaskOperation(nodeEngine.getSerializationService().toData(taskGroupImmutableInformation)),
- address)
- .invoke());
- } catch (Throwable th) {
- LOGGER.severe(String.format("%s deploy error with Exception: %s",
- this.taskFullName,
- ExceptionUtils.getMessage(th)));
- updateTaskState(ExecutionState.DEPLOYING, ExecutionState.FAILED);
- taskFuture.complete(
- new
TaskExecutionState(taskGroupImmutableInformation.getExecutionId(),
ExecutionState.FAILED, null));
- }
+ /**
+ TaskGroupImmutableInformation taskGroupImmutableInformation =
+ new TaskGroupImmutableInformation(flakeIdGenerator.newId(),
+ nodeEngine.getSerializationService().toData(this.taskGroup),
+ this.pluginJarsUrls);
+
+ try {
+ waitForCompleteByExecutionService = new NonCompletableFuture<>(
+
nodeEngine.getOperationService().createInvocationBuilder(Constant.SEATUNNEL_SERVICE_NAME,
+ new
DeployTaskOperation(nodeEngine.getSerializationService().toData(taskGroupImmutableInformation)),
+ address)
+ .invoke());
+ } catch (Throwable th) {
+ LOGGER.severe(String.format("%s deploy error with Exception: %s",
+ this.taskFullName,
+ ExceptionUtils.getMessage(th)));
+ updateTaskState(ExecutionState.DEPLOYING, ExecutionState.FAILED);
+ taskFuture.complete(
+ new
TaskExecutionState(taskGroupImmutableInformation.getExecutionId(),
ExecutionState.FAILED, null));
+ }*/
+
+ waitForCompleteByExecutionService = new
PassiveCompletableFuture<>(CompletableFuture.supplyAsync(() -> {
+ try {
+ Thread.sleep(2000);
+ } catch (InterruptedException e) {
+ throw new RuntimeException(e);
+ }
+ return new TaskExecutionState(flakeIdGenerator.newId(),
ExecutionState.FINISHED, null);
+ }));
Review Comment:
> Why not deploy the task, but simulate execution
Because TaskGroup can not serialization when this pr create, So I do it in
another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
