CalvinKirs commented on code in PR #2485:
URL:
https://github.com/apache/incubator-seatunnel/pull/2485#discussion_r953320957
##########
seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-api/src/main/java/org/apache/seatunnel/engine/checkpoint/storage/api/AbstractCheckpointStorage.java:
##########
@@ -23,36 +23,58 @@
import org.apache.seatunnel.engine.checkpoint.storage.PipelineState;
import
org.apache.seatunnel.engine.checkpoint.storage.common.ProtoStuffSerializer;
import org.apache.seatunnel.engine.checkpoint.storage.common.Serializer;
+import
org.apache.seatunnel.engine.checkpoint.storage.common.StorageThreadFactory;
import
org.apache.seatunnel.engine.checkpoint.storage.exception.CheckpointStorageException;
+import lombok.extern.slf4j.Slf4j;
+
import java.io.IOException;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+@Slf4j
public abstract class AbstractCheckpointStorage implements CheckpointStorage {
/**
* serializer,default is protostuff,if necessary, consider other
serialization methods, temporarily hard-coding
*/
private final Serializer serializer = new ProtoStuffSerializer();
+ public static final String DEFAULT_CHECKPOINT_FILE_PATH_SPLIT = "/";
+
/**
* storage root directory
+ * if not set, use default value
*/
- private static final String CHECKPOINT_DEFAULT_FILE_DIR =
"/tmp/seatunnel/checkpoint/";
+ private String storageNameSpace = "/seatunnel/checkpoint/";
Review Comment:
This seems redundant, for filesystems, which are usually configured by the
user, and if the default directory is used, the naming `${seatunnel
installation directory}` will be meaningless,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
