CalvinKirs commented on code in PR #2508:
URL:
https://github.com/apache/incubator-seatunnel/pull/2508#discussion_r954814389
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/hdfs/sink/writer/HdfsTransactionStateFileWriteFactory.java:
##########
@@ -98,8 +99,8 @@ public static TransactionStateFileWriter of(@NonNull
SeaTunnelRowType seaTunnelR
rowDelimiter,
fileSystem);
}
- // if file type not supported by file connector, default txt writer
will be generated
- return new HdfsTxtTransactionStateFileWriter(
+ if (fileFormat.equals(FileFormat.EXCEL)) {
Review Comment:
In fact, you don't need to do this, we can automatically choose the format
based on the type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
