EricJoy2048 commented on code in PR #2472: URL: https://github.com/apache/incubator-seatunnel/pull/2472#discussion_r959129331
########## seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/resourcemanager/AbstractResourceManager.java: ########## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.engine.server.resourcemanager; + +import org.apache.seatunnel.engine.common.runtime.ExecutionMode; +import org.apache.seatunnel.engine.server.SeaTunnelServer; +import org.apache.seatunnel.engine.server.resourcemanager.heartbeat.HeartbeatListener; +import org.apache.seatunnel.engine.server.resourcemanager.heartbeat.HeartbeatManager; +import org.apache.seatunnel.engine.server.resourcemanager.opeartion.ReleaseSlotOperation; +import org.apache.seatunnel.engine.server.resourcemanager.opeartion.RequestSlotOperation; +import org.apache.seatunnel.engine.server.resourcemanager.resource.ResourceProfile; +import org.apache.seatunnel.engine.server.resourcemanager.resource.SlotProfile; +import org.apache.seatunnel.engine.server.resourcemanager.worker.WorkerProfile; +import org.apache.seatunnel.engine.server.service.slot.SlotAndWorkerProfile; + +import com.google.common.collect.Lists; +import com.hazelcast.cluster.Address; +import com.hazelcast.logging.ILogger; +import com.hazelcast.logging.Logger; +import com.hazelcast.spi.impl.NodeEngine; +import com.hazelcast.spi.impl.operationservice.InvocationBuilder; +import com.hazelcast.spi.impl.operationservice.Operation; +import com.hazelcast.spi.impl.operationservice.impl.InvocationFuture; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.Executors; +import java.util.concurrent.atomic.AtomicInteger; + +public abstract class AbstractResourceManager implements ResourceManager { + + private static final long DEFAULT_WORKER_CHECK_INTERVAL = 500; + private static final ILogger LOGGER = Logger.getLogger(AbstractResourceManager.class); + + protected final Map<String, WorkerProfile> registerWorker; + + private final HeartbeatManager heartbeatManager; + private final NodeEngine nodeEngine; + + private final ExecutionMode mode = ExecutionMode.LOCAL; + + public AbstractResourceManager(NodeEngine nodeEngine) { + this.registerWorker = new ConcurrentHashMap<>(); + this.nodeEngine = nodeEngine; + this.heartbeatManager = new HeartbeatManager(new WorkerHeartbeatListener()); + } + + @Override + public void init() { + heartbeatManager.start(Executors.newSingleThreadScheduledExecutor()); + } + + @Override + public CompletableFuture<SlotProfile> applyResource(long jobId, ResourceProfile resourceProfile) throws NoEnoughResourceException { + waitingWorkerRegister(); + CompletableFuture<SlotProfile> completableFuture = new CompletableFuture<>(); + applyResources(jobId, Collections.singletonList(resourceProfile)).whenComplete((profile, error) -> { + if (error != null) { + completableFuture.completeExceptionally(error); + } else { + completableFuture.complete(profile.get(0)); + } + }); + return completableFuture; + } + + private void waitingWorkerRegister() { + if (ExecutionMode.LOCAL.equals(mode)) { + // Local mode, should wait worker(master node) register. + try { + while (registerWorker.isEmpty()) { + Thread.sleep(DEFAULT_WORKER_CHECK_INTERVAL); + } + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } + } + + @Override + public CompletableFuture<List<SlotProfile>> applyResources(long jobId, + List<ResourceProfile> resourceProfile) throws NoEnoughResourceException { + // TODO Apply for the profile with the largest resources first, and then decrease in order. In this + // way, the success rate of resource application will be higher. + waitingWorkerRegister(); + CompletableFuture<List<SlotProfile>> completableFuture = new CompletableFuture<>(); + AtomicInteger successCount = new AtomicInteger(); + Map<Integer, SlotProfile> slotProfiles = new ConcurrentHashMap<>(); + List<CompletableFuture<SlotAndWorkerProfile>> allRequestFuture = new ArrayList<>(); + for (int i = 0; i < resourceProfile.size(); i++) { + ResourceProfile r = resourceProfile.get(i); + Optional<WorkerProfile> workerProfile = + registerWorker.values().stream().filter(worker -> worker.getUnassignedResource().enoughThan(r)).findAny(); + + if (!workerProfile.isPresent()) { + workerProfile = + registerWorker.values().stream().filter(worker -> Arrays.stream(worker.getUnassignedSlots()).anyMatch(slot -> slot.getResourceProfile().enoughThan(r))).findAny(); + } + + if (workerProfile.isPresent()) { + InvocationFuture<SlotAndWorkerProfile> future = sendToMember(new RequestSlotOperation(jobId, r), workerProfile.get().getAddress()); + int finalI = i; + CompletableFuture<SlotAndWorkerProfile> internalCompletableFuture = future.whenComplete( + (slotAndWorkerProfile, error) -> { + if (error != null) { + throw new RuntimeException(error); + } else { + workerTouch(slotAndWorkerProfile.getWorkerProfile()); + if (null != slotAndWorkerProfile.getSlotProfile()) { + slotProfiles.put(finalI, slotAndWorkerProfile.getSlotProfile()); + if (successCount.incrementAndGet() == resourceProfile.size()) { + completableFuture.complete(Lists.newArrayList(slotProfiles.values())); + } + } else { + slotProfiles.put(finalI, null); + } + } + } + ); + allRequestFuture.add(internalCompletableFuture); + } else { + CompletableFuture.allOf(allRequestFuture.toArray(new CompletableFuture[0])).whenComplete((unused, error) -> { + releaseAllResourceInternal(jobId, slotProfiles.values()); + if (error != null) { + completableFuture.completeExceptionally(error); + } else { + completableFuture.completeExceptionally(new NoEnoughResourceException("can't apply resource request: " + r)); + } + } + ); + return completableFuture; + } + } + CompletableFuture.allOf(allRequestFuture.toArray(new CompletableFuture[0])).whenComplete((unused, error) -> { + if (error != null) { + releaseAllResourceInternal(jobId, slotProfiles.values()); + completableFuture.completeExceptionally(error); + } + if (slotProfiles.containsValue(null)) { + if (supportDynamicWorker()) { + List<ResourceProfile> needApplyResource = new ArrayList<>(); + List<Integer> needApplyIndex = new ArrayList<>(); + for (int i = 0; i < slotProfiles.size(); i++) { + if (slotProfiles.get(i) == null) { + needApplyResource.add(resourceProfile.get(i)); + needApplyIndex.add(i); + } + } + findNewWorker(needApplyResource); + applyResources(jobId, needApplyResource).whenComplete((s, e) -> { + if (e != null) { + releaseAllResourceInternal(jobId, slotProfiles.values()); + completableFuture.completeExceptionally(e); + return; + } + for (int i = 0; i < s.size(); i++) { + slotProfiles.put(needApplyIndex.get(i), s.get(i)); + if (successCount.incrementAndGet() == resourceProfile.size()) { + completableFuture.complete(Lists.newArrayList(slotProfiles.values())); + } + } + + }); + } else { + releaseAllResourceInternal(jobId, slotProfiles.values()); + for (int i = 0; i < slotProfiles.size(); i++) { + if (slotProfiles.get(i) == null) { + completableFuture.completeExceptionally(new NoEnoughResourceException("can't apply resource request: " + resourceProfile.get(i))); + break; + } + } + } + } + }); + return completableFuture; + } + + protected boolean supportDynamicWorker() { + return false; + } + + private void releaseAllResourceInternal(long jobId, Collection<SlotProfile> slotProfiles) { + LOGGER.warning("apply resource not success, release all already applied resource"); + slotProfiles.stream().filter(Objects::nonNull).forEach(profile -> { + releaseResource(jobId, profile); + }); + } + + /** + * find new worker in third party resource manager, it returned after worker register successes. + * + * @param resourceProfiles the worker should have resource profile list + */ + protected void findNewWorker(List<ResourceProfile> resourceProfiles) { + throw new UnsupportedOperationException("Unsupported operation to find new worker in " + this.getClass().getName()); + } + + private <E> InvocationFuture<E> sendToMember(Operation operation, Address address) { + InvocationBuilder invocationBuilder = + nodeEngine.getOperationService().createInvocationBuilder(SeaTunnelServer.SERVICE_NAME, + operation, address); + return invocationBuilder.invoke(); + } + + @Override + public CompletableFuture<Void> releaseResources(long jobId, List<SlotProfile> profiles) { + CompletableFuture<Void> completableFuture = new CompletableFuture<>(); + List<CompletableFuture<Void>> futures = new ArrayList<>(); + for (SlotProfile profile : profiles) { + futures.add(releaseResource(jobId, profile)); + } + CompletableFuture.allOf(futures.toArray(new CompletableFuture[0])).whenComplete((r, e) -> { Review Comment: I add a test about `CompletableFuture.allOf().whenComplete()` ``` public class TestFuture { public static void main(String[] args) { TestFuture tf = new TestFuture(); tf.test(); } public void test() { CompletableFuture<Void> uCompletableFuture = CompletableFuture.supplyAsync(() -> { try { Thread.sleep(1000); } catch (InterruptedException e) { throw new RuntimeException(e); } System.out.println("1111111111111"); return null; }); CompletableFuture<Void> objectCompletableFuture = CompletableFuture.supplyAsync(() -> { System.out.println("22222222222222"); return null; }); CompletableFuture<Void> objectCompletableFuture1 = CompletableFuture.supplyAsync(() -> { System.out.println("333333333333333"); return null; }); CompletableFuture<Void> objectCompletableFuture2 = CompletableFuture.supplyAsync(() -> { try { Thread.sleep(1000); } catch (InterruptedException e) { throw new RuntimeException(e); } System.out.println("error1"); throw new RuntimeException("1"); }); CompletableFuture<Void> objectCompletableFuture3 = CompletableFuture.supplyAsync(() -> { System.out.println("error2"); throw new RuntimeException("2"); }); List<CompletableFuture<Void>> list = new ArrayList<>(); list.add(uCompletableFuture); list.add(objectCompletableFuture); list.add(objectCompletableFuture1); list.add(objectCompletableFuture2); list.add(objectCompletableFuture3); CompletableFuture<Void> voidCompletableFuture = CompletableFuture.allOf(list.toArray(new CompletableFuture[list.size()])); voidCompletableFuture.whenComplete((v, t) -> { if (t != null) { System.out.println(t.getMessage()); } }); } } ``` It output message: ``` 22222222222222 333333333333333 error2 ``` It seems some future not complete. ``` CompletableFuture<Void> uCompletableFuture = CompletableFuture.supplyAsync(() -> { try { Thread.sleep(1000); } catch (InterruptedException e) { throw new RuntimeException(e); } System.out.println("1111111111111"); return null; }); ``` In your case, If one releaseResource(jobId, profile) throw a Exception, the other profiles may not be released. So if you use `CompletableFuture.allOf().whenComplete()` , you need to ensure that no Exception is throw in the `releaseResource(jobId, profile)` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
