[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2508: [Feature][ConnectorV2] add [File]excel sink

Tue, 30 Aug 2022 23:18:04 -0700 


EricJoy2048 commented on code in PR #2508:
URL: 
https://github.com/apache/incubator-seatunnel/pull/2508#discussion_r959196841


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/FileFormat.java:
##########
@@ -55,7 +55,10 @@ public ReadStrategy getReadStrategy() {
         public ReadStrategy getReadStrategy() {
             return new JsonReadStrategy();
         }
-    };
+    },
+    EXCEL("xlsx")
+    ;

Review Comment:
   > 
![image](https://user-images.githubusercontent.com/32196893/187445927-01ac825e-4526-4e40-9ede-07f5203eb7af.png)
 Do I need to implement it？I see people in the community working on Excel Source
   
   I don't think you need to implement it in this pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to