CalvinKirs commented on code in PR #2630:
URL:
https://github.com/apache/incubator-seatunnel/pull/2630#discussion_r962427455
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-http/pom.xml:
##########
@@ -25,8 +25,26 @@
<artifactId>seatunnel-connectors-spark</artifactId>
<version>${revision}</version>
</parent>
- <modelVersion>4.0.0</modelVersion>
<artifactId>seatunnel-connector-spark-http</artifactId>
+
+ <properties>
+ <httpcore.version>4.4</httpcore.version>
+ <httpclient.version>4.5.13</httpclient.version>
+ </properties>
+ <modelVersion>4.0.0</modelVersion>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ <version>${httpcore.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ <version>${httpclient.version}</version>
+ </dependency>
Review Comment:
hi, the http dependency plugin is actually a required option, and it was
previously provided as a provide item. When we extract it to the parent
dependency and provide it as a provider, it will have problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
