hailin0 commented on code in PR #2747:
URL:
https://github.com/apache/incubator-seatunnel/pull/2747#discussion_r974000489
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java:
##########
@@ -163,6 +167,73 @@ boolean checkFileType(String path) {
}
}
+ private SeaTunnelDataType<?> orcDataType2SeaTunnelDataType(TypeDescription
typeDescription) {
+ switch (typeDescription.getCategory()) {
+ case BOOLEAN:
+ return BasicType.BOOLEAN_TYPE;
+ case INT:
+ return BasicType.INT_TYPE;
+ case BYTE:
+ case SHORT:
+ case LONG:
+ return BasicType.LONG_TYPE;
+ case FLOAT:
+ case DOUBLE:
+ return BasicType.DOUBLE_TYPE;
+ case STRING:
+ case BINARY:
Review Comment:
Why not use :
```java
case BINARY:
return PrimitiveByteArrayType.INSTANCE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
