CalvinKirs commented on code in PR #2904:
URL:
https://github.com/apache/incubator-seatunnel/pull/2904#discussion_r980947315
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceReader.java:
##########
@@ -58,20 +58,22 @@ public void close() throws IOException {
@Override
@SuppressWarnings("magicnumber")
public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
- JdbcSourceSplit split = splits.poll();
- if (null != split) {
- inputFormat.open(split);
- while (!inputFormat.reachedEnd()) {
- SeaTunnelRow seaTunnelRow = inputFormat.nextRecord();
- output.collect(seaTunnelRow);
+ synchronized (output.getCheckpointLock()) {
Review Comment:
ok, but it's not ideal. We can optimize it later. Most PRs are currently
blocking on e2e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
