hailin0 commented on code in PR #2951:
URL:
https://github.com/apache/incubator-seatunnel/pull/2951#discussion_r984173318
##########
seatunnel-core/seatunnel-flink-starter/src/main/docker/Dockerfile:
##########
@@ -20,18 +20,29 @@ FROM $BASE_IMAGE
ARG SCALA_VERSION
ARG FLINK_VERSION
+ARG SEATUNNEL_VERSION
RUN mkdir -p /flink ; cd /flink ; \
tar_file=flink-${FLINK_VERSION}-bin-scala_${SCALA_VERSION}.tgz ; \
curl -LsO
https://archive.apache.org/dist/flink/flink-${FLINK_VERSION}/$tar_file ; \
tar -zxf $tar_file --strip 1 -C . ; \
rm $tar_file
-
+
Review Comment:
revert？
##########
seatunnel-core/seatunnel-spark-starter/src/main/docker/Dockerfile:
##########
@@ -29,9 +30,14 @@ RUN mkdir -p /spark ; cd /spark ; \
ENV SPARK_HOME=/spark
-WORKDIR /seatunnel
+RUN mkdir /seatunnel ; cd /seatunnel ; \
+
seatunnel_archive_name=apache-seatunnel-incubating-${SEATUNNEL_VERSION}-bin.tar.gz
; \
+ curl -LsO
https://archive.apache.org/dist/incubator/seatunnel/${SEATUNNEL_VERSION}/$seatunnel_archive_name
; \
+ tar -zxf $seatunnel_archive_name --strip 1 -C . ; \
+ rm $seatunnel_archive_name; \
+ rm -rf /seatunnel/connectors/flink*
/seatunnel/bin/start-seatunnel-{"flink","sql"}.sh
/seatunnel/lib/seatunnel-core-flink* /seatunnel/config/seatunnel-env.sh
+
-COPY target/seatunnel-core-spark.jar /seatunnel/lib/
-COPY src/main/bin /seatunnel/bin/
+WORKDIR /seatunnel
ENTRYPOINT [ "/seatunnel/bin/start-seatunnel-spark.sh" ]
Review Comment:
Need to update? same as flink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
