TyrantLucifer commented on code in PR #2646:
URL:
https://github.com/apache/incubator-seatunnel/pull/2646#discussion_r984248511
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/pom.xml:
##########
@@ -97,6 +97,17 @@
<artifactId>ali-phoenix-shaded-thin-client</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mssqlserver</artifactId>
+ <version>1.17.3</version>
Review Comment:
Using `${testcontainer.version}` instead of it.
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/AbstractSparkContainer.java:
##########
@@ -19,29 +19,25 @@
import
org.apache.seatunnel.e2e.common.container.spark.AbstractTestSparkContainer;
-import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.TestInstance;
import org.testcontainers.containers.Container;
import java.io.IOException;
-@Slf4j
Review Comment:
Please revert this file because pr #2946 has resolved problems of e2e test.
##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/AbstractFlinkContainer.java:
##########
@@ -32,22 +31,19 @@
* The before method will create a Flink cluster, and after method will close
the Flink cluster.
* You can use {@link AbstractFlinkContainer#executeJob} to submit a seatunnel
config and run a seatunnel job.
*/
-@Slf4j
Review Comment:
Please revert this file because pr #2946 has resolved problems of e2e test.
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/pom.xml:
##########
@@ -86,6 +86,16 @@
<artifactId>ali-phoenix-shaded-thin-client</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>mssqlserver</artifactId>
+ <version>1.17.3</version>
Review Comment:
Use `${testcontainer.version}` instead of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
