hailin0 commented on code in PR #2832: URL: https://github.com/apache/incubator-seatunnel/pull/2832#discussion_r1003938749
########## docs/en/connector-v2/source/TDengine.md: ########## @@ -0,0 +1,107 @@ +# TDengine Review Comment: Users mostly look for usage documents via sink list instead of source https://seatunnel.apache.org/docs/category/sink-v2 ########## seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml: ########## @@ -57,6 +56,26 @@ <artifactId>connector-console</artifactId> <version>${project.version}</version> </dependency> + <dependency> Review Comment: Do not submit example module file ########## seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/resources/examples/tdengine_to_tdengine.conf: ########## @@ -0,0 +1,86 @@ +# Review Comment: Do not submit example module files ########## seatunnel-connectors-v2-dist/pom.xml: ########## @@ -0,0 +1,193 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: why close? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
