EricJoy2048 commented on code in PR #2832: URL: https://github.com/apache/incubator-seatunnel/pull/2832#discussion_r1008706803
########## seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml: ########## @@ -18,8 +18,8 @@ --> <project xmlns="http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; Review Comment: > gitignore file contains `seatunnel-examples ` , i am curious about why doesn't it take effect The `.gitignore` only ensure the newly added files are not checked, but the existing files are still checked for changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
