[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3243: [Bug] [seatunnel-connectors-flink-kafka] When json or avro are selected for kafka schema, a ClassCastException error is reported

Tue, 01 Nov 2022 03:52:33 -0700 


CalvinKirs commented on code in PR #3243:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3243#discussion_r1010307348


##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-kafka/src/main/java/org/apache/seatunnel/flink/kafka/source/KafkaTableStream.java:
##########
@@ -110,7 +111,12 @@ public void prepare(FlinkEnvironment env) {
         }
         String schemaContent = config.getString(SCHEMA);
         format = 
FormatType.from(config.getString(SOURCE_FORMAT).trim().toLowerCase());
-        schemaInfo = JsonUtils.parseArray(schemaContent);
+        try {
+            schemaInfo = JsonUtils.stringToJsonNode(schemaContent);
+        } catch (JsonProcessingException e) {
+            e.printStackTrace();
+        }
+        

Review Comment:
   Sorry, Please ignore me, I didn't look closely at the method you used



##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-kafka/src/main/java/org/apache/seatunnel/flink/kafka/source/KafkaTableStream.java:
##########
@@ -110,7 +111,12 @@ public void prepare(FlinkEnvironment env) {
         }
         String schemaContent = config.getString(SCHEMA);
         format = 
FormatType.from(config.getString(SOURCE_FORMAT).trim().toLowerCase());
-        schemaInfo = JsonUtils.parseArray(schemaContent);
+        try {
+            schemaInfo = JsonUtils.stringToJsonNode(schemaContent);
+        } catch (JsonProcessingException e) {
+            e.printStackTrace();
+        }
+        

Review Comment:
   FYI 
   
![image](https://user-images.githubusercontent.com/16631152/199214091-272debf8-b35d-47ec-a98e-a5e2bd55ad12.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to