Hisoka-X commented on code in PR #3277:
URL:
https://github.com/apache/incubator-seatunnel/pull/3277#discussion_r1012521103
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/TableSinkFactory.java:
##########
@@ -30,6 +30,13 @@
*/
public interface TableSinkFactory<IN, StateT, CommitInfoT,
AggregatedCommitInfoT> extends Factory {
- TableSink<IN, StateT, CommitInfoT, AggregatedCommitInfoT>
createSink(TableFactoryContext context);
+ /**
+ * We will never use this method now. So gave a default implement and
return null.
+ * @param context TableFactoryContext
+ * @return
+ */
+ default TableSink<IN, StateT, CommitInfoT, AggregatedCommitInfoT>
createSink(TableFactoryContext context) {
+ return null;
Review Comment:
recommend throw `UnsupportedOperationException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
