ashulin commented on code in PR #3306:
URL:
https://github.com/apache/incubator-seatunnel/pull/3306#discussion_r1013901524
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/RequiredOption.java:
##########
@@ -159,4 +159,45 @@ public String toString() {
return String.format("Condition expression: %s, Required options:
%s", expression, ExclusiveRequiredOptions.getOptionKeys(requiredOption));
}
}
+
+ /**
+ * All options must exist or not exist at the same time
+ */
+ class BothRequiredOptions implements RequiredOption {
Review Comment:
IMO, the word `Bundled` is more appropriate than `Both`.
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/RequiredOption.java:
##########
@@ -159,4 +159,45 @@ public String toString() {
return String.format("Condition expression: %s, Required options:
%s", expression, ExclusiveRequiredOptions.getOptionKeys(requiredOption));
}
}
+
+ /**
+ * All options must exist or not exist at the same time
+ */
+ class BothRequiredOptions implements RequiredOption {
Review Comment:
```suggestion
class BundledRequiredOptions implements RequiredOption {
```
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/Options.java:
##########
@@ -187,4 +207,18 @@ public Option<T> noDefaultValue() {
return new Option<>(key, typeReference, null);
}
}
+
+ public static class NestedTypedOptionBuilder<T> extends
TypedOptionBuilder<T> {
+
+ private final Option<?>[] acceptedOptions;
+
+ NestedTypedOptionBuilder(String key, TypeReference<T> typeReference,
Option<?>[] acceptedOptions) {
+ super(key, typeReference);
+ this.acceptedOptions = acceptedOptions;
+ }
+
+ public Option<?>[] getAcceptedOptions() {
+ return acceptedOptions;
+ }
+ }
Review Comment:
`acceptedOptions` is not used.
I think it should extend `OptionRule`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
