EricJoy2048 commented on code in PR #3343: URL: https://github.com/apache/incubator-seatunnel/pull/3343#discussion_r1019790188
########## seatunnel-connectors-v2/README.zh.md: ########## @@ -149,6 +149,28 @@ Sink可以根据组件属性进行选择，到底是只实现`SinkCommitter`或` 当前版本推荐将实现SinkAggregatedCommitter作为首选，可以在Flink/Spark中提供较强的一致性保证，同时commit应该要实现幂等性，保存引擎重试能够正常运作。 +### TableSourceFactory 和 TableSinkFactory + +为了实现自动化的创建Source或者Sink，同时支持自动返回当前连接器支持的参数和所需的参数。我们定义了TableSourceFactory和TableSinkFactory， Review Comment: ```suggestion 为了实现自动化的创建Source或者Sink，我们需要连接器能够声明并返回创建他们所需要的参数列表和每个参数的校验规则。为了实现这个目标，我们定义了TableSourceFactory和TableSinkFactory， ``` ########## seatunnel-connectors-v2/README.md: ########## @@ -199,6 +199,41 @@ In the current version, it is recommended to implement ``SinkAggregatedCommitter provide strong consistency guarantee in Flink/Spark. At the same time, commit should be idempotent, and save engine retry can work normally. +### TableSourceFactory and TableSinkFactory + +In order to automatically create a Source or Sink, it also supports automatic return of the parameters Review Comment: ```suggestion In order to automatically create the Source Connector and Sink Connector and Transform Connector, we need the connector to return the parameters needed to create them and the verification rules for each parameter. For Source Connector and Sink Connector, we define `TableSourceFactory` and `TableSinkFactory` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
