EricJoy2048 commented on code in PR #3309:
URL:
https://github.com/apache/incubator-seatunnel/pull/3309#discussion_r1019796893
##########
docs/en/connector-v2/sink/Tablestore.md:
##########
@@ -0,0 +1,74 @@
+# Tablestore
+
+> Tablestore sink connector
+
+## Description
+
+Write data to `Tablestore`
+
+## Key features
+
+- [ ] [exactly-once](../../concept/connector-v2-features.md)
+- [ ] [schema projection](../../concept/connector-v2-features.md)
+
+## Options
+
+| name | type | required | default value |
+|----------------- | ------ |----------| ------------- |
+| end_point | string | yes | - |
+| instance_name | string | yes | - |
+| access_key_id | string | yes | - |
+| access_key_secret| string | yes | - |
+| table | string | yes | - |
+| primary_keys | array | yes | - |
+| batch_size | string | no | 25 |
+| batch_interval_ms| string | no | 1000 |
+| common-options | config | no | - |
+
+### end_point [string]
+
+endPoint to write to Tablestore.
+
+### instanceName [string]
+
+The instanceName of Tablestore.
+
+### access_key_id [string]
+
+The access id of Tablestore.
+
+### access_key_secret [string]
+
+The access secret of Tablestore.
+
+### table [string]
+
+The table of Tablestore.
+
+### primaryKeys [array]
+
+The primaryKeys of Tablestore.
+
+### common options
Review Comment:
```suggestion
### common options [ config ]
```
##########
docs/en/connector-v2/sink/Jdbc.md:
##########
@@ -167,4 +167,4 @@ jdbc {
- [Feature] Support SQL Server JDBC Source
([2646](https://github.com/apache/incubator-seatunnel/pull/2646))
- [Feature] Support Oracle JDBC Source
([2550](https://github.com/apache/incubator-seatunnel/pull/2550))
- [Feature] Support StarRocks JDBC Source
([3060](https://github.com/apache/incubator-seatunnel/pull/3060))
-- [Feature] Support DB2 JDBC Sink
([2410](https://github.com/apache/incubator-seatunnel/pull/2410))
\ No newline at end of file
+- [Feature] Support DB2 JDBC Sink
([2410](https://github.com/apache/incubator-seatunnel/pull/2410))
Review Comment:
Please add changed log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
