Hisoka-X commented on code in PR #3390:
URL:
https://github.com/apache/incubator-seatunnel/pull/3390#discussion_r1021041128
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -23,17 +23,16 @@
import java.util.Map;
public class HttpConfig {
- public static final String METHOD_DEFAULT_VALUE = "GET";
public static final String DEFAULT_FORMAT = "json";
public static final int DEFAULT_RETRY_BACKOFF_MULTIPLIER_MS = 100;
public static final int DEFAULT_RETRY_BACKOFF_MAX_MS = 10000;
public static final Option<String> URL = Options.key("url")
.stringType()
.noDefaultValue()
.withDescription("Http request url");
- public static final Option<String> METHOD = Options.key("method")
- .stringType()
- .defaultValue(METHOD_DEFAULT_VALUE)
+ public static final Option<HttpRequestMethod> METHOD =
Options.key("method")
+ .objectType(HttpRequestMethod.class)
Review Comment:
please use `enumType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
