wolfboys commented on code in PR #3468:
URL:
https://github.com/apache/incubator-seatunnel/pull/3468#discussion_r1027289372
##########
seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/FlinkEnvironment.java:
##########
@@ -92,12 +81,8 @@ public CheckResult checkConfig() {
@Override
public FlinkEnvironment prepare() {
// Batch/Streaming both use data stream api in SeaTunnel New API
- createStreamEnvironment();
- createStreamTableEnvironment();
- if (!isStreaming()) {
- createExecutionEnvironment();
- createBatchTableEnvironment();
- }
+ createEnvironment();
+ createTableEnvironment();
if (config.hasPath("job.name")) {
Review Comment:
I suggest that such generic parameters be extracted as constants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
