This is an automated email from the ASF dual-hosted git repository.

fanjia pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 7f1285f14 [Feature][Transform V2] expose configurable options in 
FilterFieldTransform (#3495)
7f1285f14 is described below

commit 7f1285f149dfab4aef21986c1738574913b99646
Author: TaoZex <[email protected]>
AuthorDate: Tue Nov 22 10:49:43 2022 +0800

    [Feature][Transform V2] expose configurable options in FilterFieldTransform 
(#3495)
---
 .../seatunnel/transform/FilterFieldTransform.java  | 14 +++++---
 .../transform/FilterFieldTransformFactory.java     | 41 ++++++++++++++++++++++
 2 files changed, 51 insertions(+), 4 deletions(-)

diff --git 
a/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransform.java
 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransform.java
index 96ae112c7..7d69f2c95 100644
--- 
a/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransform.java
+++ 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransform.java
@@ -17,6 +17,8 @@
 
 package org.apache.seatunnel.transform;
 
+import org.apache.seatunnel.api.configuration.Option;
+import org.apache.seatunnel.api.configuration.Options;
 import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
 import org.apache.seatunnel.api.table.type.SeaTunnelRow;
 import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
@@ -28,11 +30,15 @@ import 
org.apache.seatunnel.shade.com.typesafe.config.Config;
 import com.google.auto.service.AutoService;
 import lombok.extern.slf4j.Slf4j;
 
+import java.util.List;
+
 @Slf4j
 @AutoService(SeaTunnelTransform.class)
 public class FilterFieldTransform extends AbstractSeaTunnelTransform {
-
-    private static final String KEY_FIELDS = "fields";
+    public static final Option<List<String>> KEY_FIELDS = Options.key("fields")
+            .listType()
+            .noDefaultValue()
+            .withDescription("The fields you want to filter");
 
     private String[] fields;
     private int[] inputValueIndex;
@@ -44,10 +50,10 @@ public class FilterFieldTransform extends 
AbstractSeaTunnelTransform {
 
     @Override
     protected void setConfig(Config pluginConfig) {
-        if (!pluginConfig.hasPath(KEY_FIELDS)) {
+        if (!pluginConfig.hasPath(KEY_FIELDS.key())) {
             throw new IllegalArgumentException("The configuration missing key: 
" + KEY_FIELDS);
         }
-        this.fields = pluginConfig.getStringList(KEY_FIELDS).toArray(new 
String[0]);
+        this.fields = pluginConfig.getStringList(KEY_FIELDS.key()).toArray(new 
String[0]);
     }
 
     @Override
diff --git 
a/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransformFactory.java
 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransformFactory.java
new file mode 100644
index 000000000..bd1691f9f
--- /dev/null
+++ 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/FilterFieldTransformFactory.java
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.transform;
+
+import static org.apache.seatunnel.transform.FilterFieldTransform.KEY_FIELDS;
+
+import org.apache.seatunnel.api.configuration.util.OptionRule;
+import org.apache.seatunnel.api.table.factory.Factory;
+import org.apache.seatunnel.api.table.factory.TableTransformFactory;
+
+import com.google.auto.service.AutoService;
+
+@AutoService(Factory.class)
+public class FilterFieldTransformFactory implements TableTransformFactory{
+    @Override
+    public String factoryIdentifier() {
+        return "Filter";
+    }
+
+    @Override
+    public OptionRule optionRule() {
+        return OptionRule.builder()
+                .required(KEY_FIELDS)
+                .build();
+    }
+}

Reply via email to