This is an automated email from the ASF dual-hosted git repository.

tyrantlucifer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new e720220db [Feature][Transform-V2][Replace] Expose configurable options 
in ReplaceTransform (#3497)
e720220db is described below

commit e720220db7039120044e1de477273a6228beed15
Author: TaoZex <[email protected]>
AuthorDate: Tue Nov 22 11:52:22 2022 +0800

    [Feature][Transform-V2][Replace] Expose configurable options in 
ReplaceTransform (#3497)
---
 .../seatunnel/transform/ReplaceTransform.java      | 47 ++++++++++++++++------
 .../transform/ReplaceTransformFactory.java         | 47 ++++++++++++++++++++++
 2 files changed, 81 insertions(+), 13 deletions(-)

diff --git 
a/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransform.java
 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransform.java
index 310164062..a7101558e 100644
--- 
a/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransform.java
+++ 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransform.java
@@ -17,6 +17,8 @@
 
 package org.apache.seatunnel.transform;
 
+import org.apache.seatunnel.api.configuration.Option;
+import org.apache.seatunnel.api.configuration.Options;
 import org.apache.seatunnel.api.table.type.BasicType;
 import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
 import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
@@ -33,11 +35,30 @@ import com.google.auto.service.AutoService;
 @AutoService(SeaTunnelTransform.class)
 public class ReplaceTransform extends SingleFieldOutputTransform {
 
-    private static final String KEY_REPLACE_FIELD = "replace_field";
-    private static final String KEY_PATTERN = "pattern";
-    private static final String KEY_REPLACEMENT = "replacement";
-    private static final String KEY_IS_REGEX = "is_regex";
-    private static final String KEY_REPLACE_FIRST = "replace_first";
+    public static final Option<String> KEY_REPLACE_FIELD = 
Options.key("replace_field")
+            .stringType()
+            .noDefaultValue()
+            .withDescription("The field you want to replace");
+
+    public static final Option<String> KEY_PATTERN = Options.key("pattern")
+            .stringType()
+            .noDefaultValue()
+            .withDescription("The old string that will be replaced");
+
+    public static final Option<String> KEY_REPLACEMENT = 
Options.key("replacement")
+            .stringType()
+            .noDefaultValue()
+            .withDescription("The new string for replace");
+
+    public static final Option<Boolean> KEY_IS_REGEX = Options.key("is_regex")
+            .booleanType()
+            .defaultValue(false)
+            .withDescription("Use regex for string match");
+
+    public static final Option<Boolean> KEY_REPLACE_FIRST = 
Options.key("replace_first")
+            .booleanType()
+            .defaultValue(false)
+            .withDescription("Replace the first match string");
 
     private int inputFieldIndex;
     private String replaceField;
@@ -54,19 +75,19 @@ public class ReplaceTransform extends 
SingleFieldOutputTransform {
     @Override
     protected void setConfig(Config pluginConfig) {
         CheckResult checkResult = CheckConfigUtil.checkAllExists(pluginConfig,
-            KEY_REPLACE_FIELD, KEY_PATTERN, KEY_REPLACEMENT);
+            KEY_REPLACE_FIELD.key(), KEY_PATTERN.key(), KEY_REPLACEMENT.key());
         if (!checkResult.isSuccess()) {
             throw new IllegalArgumentException("Failed to check config! " + 
checkResult.getMsg());
         }
 
-        replaceField = pluginConfig.getString(KEY_REPLACE_FIELD);
-        pattern = pluginConfig.getString(KEY_PATTERN);
-        replacement = pluginConfig.getString(KEY_REPLACEMENT);
-        if (pluginConfig.hasPath(KEY_IS_REGEX)) {
-            isRegex = pluginConfig.getBoolean(KEY_IS_REGEX);
+        replaceField = pluginConfig.getString(KEY_REPLACE_FIELD.key());
+        pattern = pluginConfig.getString(KEY_PATTERN.key());
+        replacement = pluginConfig.getString(KEY_REPLACEMENT.key());
+        if (pluginConfig.hasPath(KEY_IS_REGEX.key())) {
+            isRegex = pluginConfig.getBoolean(KEY_IS_REGEX.key());
         }
-        if (pluginConfig.hasPath(KEY_REPLACE_FIRST)) {
-            replaceFirst = pluginConfig.getBoolean(KEY_REPLACE_FIRST);
+        if (pluginConfig.hasPath(KEY_REPLACE_FIRST.key())) {
+            replaceFirst = pluginConfig.getBoolean(KEY_REPLACE_FIRST.key());
         }
     }
 
diff --git 
a/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransformFactory.java
 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransformFactory.java
new file mode 100644
index 000000000..88372e6e3
--- /dev/null
+++ 
b/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/ReplaceTransformFactory.java
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.transform;
+
+import static org.apache.seatunnel.transform.ReplaceTransform.KEY_IS_REGEX;
+import static org.apache.seatunnel.transform.ReplaceTransform.KEY_PATTERN;
+import static org.apache.seatunnel.transform.ReplaceTransform.KEY_REPLACEMENT;
+import static 
org.apache.seatunnel.transform.ReplaceTransform.KEY_REPLACE_FIELD;
+import static 
org.apache.seatunnel.transform.ReplaceTransform.KEY_REPLACE_FIRST;
+
+import org.apache.seatunnel.api.configuration.util.Condition;
+import org.apache.seatunnel.api.configuration.util.OptionRule;
+import org.apache.seatunnel.api.table.factory.Factory;
+import org.apache.seatunnel.api.table.factory.TableTransformFactory;
+
+import com.google.auto.service.AutoService;
+
+@AutoService(Factory.class)
+public class ReplaceTransformFactory implements TableTransformFactory {
+    @Override
+    public String factoryIdentifier() {
+        return "Replace";
+    }
+
+    @Override
+    public OptionRule optionRule() {
+        return OptionRule.builder()
+                .required(KEY_REPLACE_FIELD, KEY_PATTERN, KEY_REPLACEMENT)
+                .conditional(Condition.of(KEY_IS_REGEX, true), 
KEY_REPLACE_FIRST)
+                .build();
+    }
+}

Reply via email to