EricJoy2048 commented on code in PR #3383:
URL:
https://github.com/apache/incubator-seatunnel/pull/3383#discussion_r1028859128
##########
seatunnel-connectors-v2/connector-hudi/src/main/java/org/apache/seatunnel/connectors/seatunnel/hudi/config/HudiSourceConfig.java:
##########
@@ -17,18 +17,44 @@
package org.apache.seatunnel.connectors.seatunnel.hudi.config;
-public class HudiSourceConfig {
-
- public static final String TABLE_PATH = "table.path";
-
- public static final String TABLE_TYPE = "table.type";
-
- public static final String CONF_FILES = "conf.files";
+import org.apache.seatunnel.api.configuration.Option;
+import org.apache.seatunnel.api.configuration.Options;
- public static final String USE_KERBEROS = "use.kerberos";
-
- public static final String KERBEROS_PRINCIPAL = "kerberos.principal";
-
- public static final String KERBEROS_PRINCIPAL_FILE =
"kerberos.principal.file";
+public class HudiSourceConfig {
+ public static final Option<String> TABLE_PATH =
+ Options.key("table.path")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("hudi table path");
+
+ public static final Option<String> TABLE_TYPE =
+ Options.key("table.type")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("hudi table type. default hudi table type
is cow. mor is not support yet");
+
+ public static final Option<String> CONF_FILES =
+ Options.key("conf.files")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("hudi conf files ");
+
+ public static final Option<Boolean> USE_KERBEROS =
+ Options.key("use.kerberos")
+ .booleanType()
+ .defaultValue(false)
Review Comment:
> Should we make `use_kerberos` as an enum type option?
Sorry, You don't need update it to enum type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
