TyrantLucifer commented on code in PR #3563:
URL:
https://github.com/apache/incubator-seatunnel/pull/3563#discussion_r1031155066
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSinkWriter.java:
##########
@@ -122,7 +124,7 @@ public void close() throws IOException {
intHolder.setValue(0);
}
} catch (SQLException e) {
- throw new RuntimeException("Failed to close prepared
statement.", e);
+ throw new
ClickhouseConnectorException(CommonErrorCode.WRITER_OPERATION_FAILED, "Failed
to close prepared statement.", e);
Review Comment:
CommonErrorCode.SQL_OPERATION_FAILED is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
