TyrantLucifer commented on code in PR #3574:
URL:
https://github.com/apache/incubator-seatunnel/pull/3574#discussion_r1032737397
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java:
##########
@@ -124,7 +127,8 @@ public void close() {
try (KafkaProduceSender<?, ?> kafkaProduceSender =
kafkaProducerSender) {
// no-opt
} catch (Exception e) {
- throw new RuntimeException("Close kafka sink writer error", e);
+ throw new
KafkaConnectorException(KafkaConnectorErrorCode.CLOSE_SINK_WRITER_FAILED,
Review Comment:
Common.WRITER_OPERATION_FAILED is better, remove useless error code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
