TyrantLucifer commented on code in PR #3582:
URL:
https://github.com/apache/incubator-seatunnel/pull/3582#discussion_r1032861137
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/serialize/DefaultSeaTunnelRowSerializer.java:
##########
@@ -61,7 +61,11 @@ public DefaultSeaTunnelRowSerializer(String topic,
@Override
public ProducerRecord<byte[], byte[]> serializeRow(SeaTunnelRow row) {
- return new ProducerRecord<>(topic, partition,
+ if (partition != -1) {
+ return new ProducerRecord<>(topic, partition,
+ keySerialization.serialize(row),
valueSerialization.serialize(row));
+ }
+ return new ProducerRecord<>(topic,
keySerialization.serialize(row),
valueSerialization.serialize(row));
Review Comment:
```suggestion
return new ProducerRecord<>(topic, partition,
keySerialization.serialize(row),
valueSerialization.serialize(row));
```
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/serialize/DefaultSeaTunnelRowSerializer.java:
##########
@@ -30,7 +30,7 @@
public class DefaultSeaTunnelRowSerializer implements
SeaTunnelRowSerializer<byte[], byte[]> {
- private Integer partition;
+ private Integer partition = -1;
Review Comment:
```suggestion
private Integer partition = null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
