john8628 commented on code in PR #3590:
URL:
https://github.com/apache/incubator-seatunnel/pull/3590#discussion_r1034732964
##########
seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/enumerator/PulsarSplitEnumerator.java:
##########
@@ -107,10 +109,10 @@ public
PulsarSplitEnumerator(SourceSplitEnumerator.Context<PulsarPartitionSplit>
StopCursor stopCursor,
String subscriptionName,
Set<TopicPartition> assignedPartitions) {
- if ((partitionDiscoverer instanceof TopicPatternDiscoverer)
+ if (partitionDiscoverer instanceof TopicPatternDiscoverer
&& partitionDiscoveryIntervalMs > 0
&& Boundedness.BOUNDED == stopCursor.getBoundedness()) {
- throw new IllegalArgumentException("Bounded streams do not support
dynamic partition discovery.");
+ throw new
PulsarConnectorException(PulsarConnectorErrorCode.UNSUPPORTED_OPERATION,
"Bounded streams do not support dynamic partition discovery.");
Review Comment:
Ok, thank you for your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
