This is an automated email from the ASF dual-hosted git repository.

wuchunfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 97cce8c25 [Improve][Connector-V2][OneSignal]Unified exception for 
OneSignal connector (#3609)
97cce8c25 is described below

commit 97cce8c25562d077e1a13870f1cbaff28008e590
Author: Solomon-aka-beatsAll 
<[email protected]>
AuthorDate: Thu Dec 1 17:59:52 2022 +0800

    [Improve][Connector-V2][OneSignal]Unified exception for OneSignal connector 
(#3609)
    
    * Unified exception for OneSignal
    
    * [Improve][Connector-V2][OneSignal]Unified exception for OneSignal 
connector
    
    * [Improve][Connector-V2][OneSignal]Unified exception for OneSignal 
connector
    
    * [Improve][Connector-V2][OneSignal]Unified exception for OneSignal 
connector
    
    * [Improve][Connector-V2][OneSignal]Unified exception for OneSignal 
connector
    
    * [Improve][Connector-V2][OneSignal]Unified exception for OneSignal 
connector
---
 .../onesignal/source/OneSignalSource.java          |  6 +++-
 .../exception/OneSignalConnectorException.java     | 35 ++++++++++++++++++++++
 2 files changed, 40 insertions(+), 1 deletion(-)

diff --git 
a/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/OneSignalSource.java
 
b/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/OneSignalSource.java
index f5b47d487..eec023d2d 100644
--- 
a/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/OneSignalSource.java
+++ 
b/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/OneSignalSource.java
@@ -18,6 +18,7 @@
 package org.apache.seatunnel.connectors.seatunnel.onesignal.source;
 
 import org.apache.seatunnel.api.common.PrepareFailException;
+import org.apache.seatunnel.api.common.SeaTunnelAPIErrorCode;
 import org.apache.seatunnel.api.source.SeaTunnelSource;
 import org.apache.seatunnel.api.table.type.SeaTunnelRow;
 import org.apache.seatunnel.common.config.CheckConfigUtil;
@@ -29,6 +30,7 @@ import 
org.apache.seatunnel.connectors.seatunnel.http.source.HttpSource;
 import org.apache.seatunnel.connectors.seatunnel.http.source.HttpSourceReader;
 import 
org.apache.seatunnel.connectors.seatunnel.onesignal.source.config.OneSignalSourceConfig;
 import 
org.apache.seatunnel.connectors.seatunnel.onesignal.source.config.OneSignalSourceParameter;
+import 
org.apache.seatunnel.connectors.seatunnel.onesignal.source.config.exception.OneSignalConnectorException;
 
 import org.apache.seatunnel.shade.com.typesafe.config.Config;
 
@@ -48,7 +50,9 @@ public class OneSignalSource extends HttpSource {
     public void prepare(Config pluginConfig) throws PrepareFailException {
         CheckResult result = CheckConfigUtil.checkAllExists(pluginConfig, 
OneSignalSourceConfig.URL.key(), OneSignalSourceConfig.PASSWORD.key());
         if (!result.isSuccess()) {
-            throw new PrepareFailException(getPluginName(), PluginType.SOURCE, 
result.getMsg());
+            throw new 
OneSignalConnectorException(SeaTunnelAPIErrorCode.CONFIG_VALIDATION_FAILED,
+                String.format("PluginName: %s, PluginType: %s, Message: %s",
+                    getPluginName(), PluginType.SOURCE, result.getMsg()));
         }
         oneSignalSourceParameter.buildWithConfig(pluginConfig);
         buildSchemaWithConfig(pluginConfig);
diff --git 
a/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/config/exception/OneSignalConnectorException.java
 
b/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/config/exception/OneSignalConnectorException.java
new file mode 100644
index 000000000..76b6d93ac
--- /dev/null
+++ 
b/seatunnel-connectors-v2/connector-http/connector-http-onesignal/src/main/java/org/apache/seatunnel/connectors/seatunnel/onesignal/source/config/exception/OneSignalConnectorException.java
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package 
org.apache.seatunnel.connectors.seatunnel.onesignal.source.config.exception;
+
+import org.apache.seatunnel.common.exception.SeaTunnelErrorCode;
+import org.apache.seatunnel.common.exception.SeaTunnelRuntimeException;
+
+public class OneSignalConnectorException extends SeaTunnelRuntimeException {
+    public OneSignalConnectorException(SeaTunnelErrorCode seaTunnelErrorCode, 
String errorMessage) {
+        super(seaTunnelErrorCode, errorMessage);
+    }
+
+    public OneSignalConnectorException(SeaTunnelErrorCode seaTunnelErrorCode, 
String errorMessage, Throwable cause) {
+        super(seaTunnelErrorCode, errorMessage, cause);
+    }
+
+    public OneSignalConnectorException(SeaTunnelErrorCode seaTunnelErrorCode, 
Throwable cause) {
+        super(seaTunnelErrorCode, cause);
+    }
+}

Reply via email to