liugddx commented on code in PR #3696: URL: https://github.com/apache/incubator-seatunnel/pull/3696#discussion_r1046599093
########## seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/hazelcast.yaml: ########## @@ -0,0 +1,37 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +hazelcast: + cluster-name: seatunnel + network: + join: + tcp-ip: + enabled: true + member-list: + - localhost + port: + auto-increment: true + port-count: 100 + port: 5801 + map: + map-name-template: + map-store: + enabled: true + initial-mode: EAGER + class-name: org.apache.seatunnel.engine.server.persistence.FileMapStore + properties: + path: /tmp/file-store-map Review Comment: ```suggestion map: engine*: map-store: enabled: true initial-mode: EAGER factory-class-name: org.apache.seatunnel.engine.server.persistence.FileMapStoreFactory properties: namespace: /tmp/seatunnel/imap clusterName: seatunnel-clsuter fs.defaultFS: file:/// ``` ########## seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/pom.xml: ########## @@ -37,9 +45,16 @@ <scope>provided</scope> </dependency> <dependency> - <groupId>org.apache.hadoop</groupId> - <artifactId>hadoop-client</artifactId> - <version>3.0.0</version> + <groupId>com.amazonaws</groupId> + <artifactId>aws-java-sdk-bundle</artifactId> + <version>1.11.199</version> Review Comment: Manage versions in the parent pom. ########## seatunnel-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/pom.xml: ########## @@ -37,9 +45,16 @@ <scope>provided</scope> </dependency> <dependency> - <groupId>org.apache.hadoop</groupId> - <artifactId>hadoop-client</artifactId> - <version>3.0.0</version> + <groupId>com.amazonaws</groupId> + <artifactId>aws-java-sdk-bundle</artifactId> + <version>1.11.199</version> + <scope>provided</scope> + </dependency> + <!-- https://mvnrepository.com/artifact/org.apache.flink/flink-shaded-hadoop-3-uber --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-shaded-hadoop-3-uber</artifactId> + <version>3.1.1.7.2.9.0-173-9.0</version> Review Comment: Manage versions in the parent pom. ########## seatunnel-engine/seatunnel-engine-common/src/main/resources/hazelcast.yaml: ########## @@ -32,7 +27,11 @@ hazelcast: auto-increment: true port-count: 100 port: 5801 - properties: - hazelcast.invocation.max.retry.count: 20 - hazelcast.tcp.join.port.try.count: 30 - hazelcast.logging.type: log4j2 + map: + map-name-template: + map-store: + enabled: true + initial-mode: EAGER + class-name: org.apache.seatunnel.engine.server.persistence.FileMapStore + properties: + path: /tmp/file-store-map Review Comment: We only need to persist part of the IMap. It should be like this. ```suggestion map: engine*: map-store: enabled: true initial-mode: EAGER factory-class-name: org.apache.seatunnel.engine.server.persistence.FileMapStoreFactory properties: namespace: /tmp/seatunnel/imap clusterName: seatunnel-clsuter fs.defaultFS: file:/// ``` ########## seatunnel-engine/seatunnel-engine-common/src/main/resources/hazelcast.yaml: ########## @@ -32,7 +27,11 @@ hazelcast: auto-increment: true port-count: 100 port: 5801 - properties: - hazelcast.invocation.max.retry.count: 20 - hazelcast.tcp.join.port.try.count: 30 - hazelcast.logging.type: log4j2 + map: + map-name-template: + map-store: + enabled: true + initial-mode: EAGER + class-name: org.apache.seatunnel.engine.server.persistence.FileMapStore + properties: + path: /tmp/file-store-map Review Comment: The IMap we need to persist should have a uniform prefix, like `engine_runningJobInfo` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
