hailin0 commented on code in PR #3745:
URL:
https://github.com/apache/incubator-seatunnel/pull/3745#discussion_r1051302971
##########
seatunnel-connectors-v2/connector-console/src/main/java/org/apache/seatunnel/connectors/seatunnel/console/sink/ConsoleSinkWriter.java:
##########
@@ -53,7 +55,7 @@ public void write(SeaTunnelRow element) {
for (int i = 0; i < fieldTypes.length; i++) {
arr[i] = fieldToString(fieldTypes[i], fields[i]);
}
- System.out.format("subtaskIndex=%s: row=%s : %s%n",
context.getIndexOfSubtask(), CNT.incrementAndGet(), StringUtils.join(arr, ",
"));
+ log.info("subtaskIndex={}: row={} : {}", context.getIndexOfSubtask(),
CNT.incrementAndGet(), StringUtils.join(arr, ", "));
Review Comment:
suggest output SeaTunnelRow#tableId, SeaTunnelRow#kind
##########
seatunnel-connectors-v2/connector-console/src/main/java/org/apache/seatunnel/connectors/seatunnel/console/sink/ConsoleSinkWriter.java:
##########
@@ -40,8 +42,8 @@ public class ConsoleSinkWriter extends
AbstractSinkWriter<SeaTunnelRow, Void> {
public ConsoleSinkWriter(SeaTunnelRowType seaTunnelRowType,
SinkWriter.Context context) {
this.seaTunnelRowType = seaTunnelRowType;
this.context = context;
- System.out.printf("fields : %s%n",
StringUtils.join(seaTunnelRowType.getFieldNames(), ", "));
- System.out.printf("types : %s%n",
StringUtils.join(seaTunnelRowType.getFieldTypes(), ", "));
+ log.info("fields: {}",
StringUtils.join(seaTunnelRowType.getFieldNames(), ", "));
+ log.info("types: {}",
StringUtils.join(seaTunnelRowType.getFieldTypes(), ", "));
Review Comment:
The suggested output format is：`A<INT>, B<STRING>, C<BOOLEAN>,...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
