TaoZex commented on code in PR #3750:
URL:
https://github.com/apache/incubator-seatunnel/pull/3750#discussion_r1056925652
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceSplitEnumerator.java:
##########
@@ -38,16 +42,28 @@ public class JdbcSourceSplitEnumerator implements
SourceSplitEnumerator<JdbcSour
private static final Logger LOG =
LoggerFactory.getLogger(JdbcSourceSplitEnumerator.class);
private final SourceSplitEnumerator.Context<JdbcSourceSplit>
enumeratorContext;
- private final Map<Integer, Set<JdbcSourceSplit>> pendingSplits;
+ private final Map<Integer, List<JdbcSourceSplit>> pendingSplits;
+
+ private final Object stateLock = new Object();
+ private volatile boolean shouldEnumerate;
private JdbcSourceOptions jdbcSourceOptions;
private final PartitionParameter partitionParameter;
public
JdbcSourceSplitEnumerator(SourceSplitEnumerator.Context<JdbcSourceSplit>
enumeratorContext, JdbcSourceOptions jdbcSourceOptions, PartitionParameter
partitionParameter) {
+ this(enumeratorContext, jdbcSourceOptions, partitionParameter, null);
+ }
+
+ public
JdbcSourceSplitEnumerator(SourceSplitEnumerator.Context<JdbcSourceSplit>
enumeratorContext, JdbcSourceOptions jdbcSourceOptions, PartitionParameter
partitionParameter, JdbcSourceState sourceState) {
this.enumeratorContext = enumeratorContext;
this.jdbcSourceOptions = jdbcSourceOptions;
this.partitionParameter = partitionParameter;
this.pendingSplits = new HashMap<>();
+ this.shouldEnumerate = sourceState == null;
Review Comment:
```suggestion
this.shouldEnumerate = sourceState == null ? true : false;
```
How about using this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
